Ran oxc (https://oxc.rs/docs/guide/usage/linter.html#vscode-extension) and fixed all the issues that came up, set it up to run as a PR check and added steps to the README.md asking users to use it. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Introduced JavaScript linting using oxlint in development guidelines and CI workflow for improved code quality. * Added oxlint configuration and dependencies to the project. * **Bug Fixes** * Improved error logging in various components and utilities for better debugging. * Enhanced React list rendering by updating keys to use unique values instead of array indices, reducing rendering issues. * Replaced browser alerts with toast notifications for a smoother user experience. * **Refactor** * Simplified component logic and state management by removing unused code, imports, props, and components across multiple files. * Updated function and component signatures for clarity and maintainability. * Improved efficiency of certain operations by switching from arrays to sets for membership checks. * **Chores** * Cleaned up and reorganized import statements throughout the codebase. * Removed deprecated files, components, and middleware to streamline the codebase. * **Documentation** * Updated contribution guidelines to include linting requirements for code submissions. * **Style** * Minor formatting and readability improvements in JSX and code structure. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Scripts
This folder contains utility scripts for the Zero email application. These scripts are designed to help with development, testing, and maintenance tasks that are not part of the main application flow.
Overview
The scripts system in Zero is built using cmd-ts, a TypeScript library for building type-safe command-line applications. This provides a structured way to create, organize, and run utility scripts with proper command-line argument handling, help text, and more.
How to Run Scripts
Scripts can be run using the scripts command from the project root:
# Run a script from the project root
pnpm scripts <script-name> [options]
# Example: Run the seed-style script
pnpm scripts seed-style
This command is defined in the root package.json and executes the script runner in the mail app:
"scripts": "dotenv -- pnpm run --cwd apps/mail --silent --elide-lines=0 scripts"
Available Scripts
seed-style
Seeds the writing style matrix for a given connection with sample emails of different styles. This is useful for testing and developing the writing style features of the application.
Usage:
# Interactive mode (will prompt for options)
pnpm scripts seed-style
# With command-line options
pnpm scripts seed-style seed --connection-id <id> --style <style> --size <number> [--reset]
# Or reset the style matrix
pnpm scripts seed-style reset --connection-id <id>
Options:
--connection-id, -c: The connection ID to seed the style matrix for--style, -s: The style to use (professional, persuasive, genz, concise, friendly)--size, -n: Number of emails to seed (default: 10)--reset, -r: Reset the style matrix before seeding
Subcommands:
seed: Seeds the style matrix with sample emailsreset: Resets the style matrix for a connection
How to Add New Scripts
To add a new script to the system:
- Create a new script file in the
apps/mail/scriptsdirectory or a subdirectory - Export a command object using the cmd-ts library
- Register the command in
apps/mail/scripts/run.ts
Step 1: Create a new script file
Create a new TypeScript file for your script. For example, apps/mail/scripts/my-script.ts:
import { command, option, string as stringType } from 'cmd-ts';
export const myScriptCommand = command({
name: 'my-script',
description: 'Description of what my script does',
args: {
// Define command-line arguments
param1: option({
type: stringType,
long: 'param1',
short: 'p',
description: 'Description of param1',
}),
},
handler: async (inputs) => {
// Script implementation
console.log(`Running my script with param1: ${inputs.param1}`);
// Do something useful here
},
});
Step 2: Register the command
Update apps/mail/scripts/run.ts to include your new command:
import { seedStyleCommand } from '@zero/mail/scripts/seed-style/seeder';
import { myScriptCommand } from '@zero/mail/scripts/my-script';
import { subcommands, run } from 'cmd-ts';
const app = subcommands({
name: 'scripts',
cmds: {
'seed-style': seedStyleCommand,
'my-script': myScriptCommand, // Add your new command here
},
});
await run(app, process.argv.slice(2));
process.exit(0);
Step 3: Run your script
You can now run your script using:
pnpm scripts my-script --param1 value
Best Practices
When creating scripts:
- Use cmd-ts features: Take advantage of the cmd-ts library for argument parsing, validation, and help text
- Interactive mode: Consider supporting both interactive mode (using prompts) and command-line options
- Error handling: Implement proper error handling and provide useful error messages
- Documentation: Document your script's purpose, usage, and options in this README
- Modularity: Break complex scripts into smaller, reusable functions
- Testing: Consider adding tests for critical script functionality
Dependencies
The scripts system uses several key dependencies:
- cmd-ts: Command-line parsing and execution
- @inquirer/prompts: Interactive command-line prompts
- p-all: Run promises in parallel with limited concurrency
- p-retry: Retry failed promises