From 042ddf16e17df3566bbfe4b80bedb5056072d3b8 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 20 Apr 2026 18:00:08 +0000 Subject: [PATCH] fix: address code review comments in RefreshMetadataDialog Agent-Logs-Url: https://github.com/rommapp/romm/sessions/fec651c3-d741-4c7d-a79f-bd469343602e Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com> --- .../components/common/Game/Dialog/RefreshMetadata.vue | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/common/Game/Dialog/RefreshMetadata.vue b/frontend/src/components/common/Game/Dialog/RefreshMetadata.vue index 45c999b62..377951b78 100644 --- a/frontend/src/components/common/Game/Dialog/RefreshMetadata.vue +++ b/frontend/src/components/common/Game/Dialog/RefreshMetadata.vue @@ -25,7 +25,7 @@ const scanningStore = storeScanning(); const configStore = storeConfig(); const { config } = storeToRefs(configStore); -const calculateHashes = computed(() => !config.value.SKIP_HASH_CALCULATION || false); +const calculateHashes = computed(() => !config.value.SKIP_HASH_CALCULATION); const metadataOptions = computed(() => { return heartbeat.getMetadataOptionsByPriority().map((option) => { @@ -58,10 +58,13 @@ const launchboxRemoteEnabled = useLocalStorage( true, ); +const filteredMetadataSources = metadataOptions.value.filter( + (m) => storedMetadataSources.value.includes(m.value) && !m.disabled, +); const metadataSources = ref( - metadataOptions.value.filter( - (m) => storedMetadataSources.value.includes(m.value) && !m.disabled, - ) || heartbeat.getEnabledMetadataOptions(), + filteredMetadataSources.length > 0 + ? filteredMetadataSources + : heartbeat.getEnabledMetadataOptions(), ); const isLaunchboxSelected = computed(() =>