From c41e8ec40f83b78097d8f019e98ef86090a3488c Mon Sep 17 00:00:00 2001
From: zurdi <zurdizurdo25@gmail.com>
Date: Fri, 25 Oct 2024 16:19:53 +0000
Subject: [PATCH 1/2] fixed rom personal details on mobile

---
 frontend/src/components/Details/Personal.vue | 194 +++++++++++--------
 frontend/src/utils/index.ts                  |  25 ++-
 2 files changed, 140 insertions(+), 79 deletions(-)

diff --git a/frontend/src/components/Details/Personal.vue b/frontend/src/components/Details/Personal.vue
index f383f82f5..bbe0d72a3 100644
--- a/frontend/src/components/Details/Personal.vue
+++ b/frontend/src/components/Details/Personal.vue
@@ -3,40 +3,27 @@ import romApi from "@/services/api/rom";
 import storeAuth from "@/stores/auth";
 import type { DetailedRom } from "@/stores/roms";
 import type { RomUserStatus } from "@/__generated__";
-import { getTextForStatus } from "@/utils";
+import { difficultyEmojis, getTextForStatus, getEmojiForStatus } from "@/utils";
 import { MdEditor, MdPreview } from "md-editor-v3";
 import "md-editor-v3/lib/style.css";
 import { ref, watch } from "vue";
-import { useTheme } from "vuetify";
+import { useDisplay, useTheme } from "vuetify";
 
 const props = defineProps<{ rom: DetailedRom }>();
 const auth = storeAuth();
 const theme = useTheme();
+const { smAndDown } = useDisplay();
 const editingNote = ref(false);
 const romUser = ref(props.rom.rom_user);
 const publicNotes =
   props.rom.user_notes?.filter((note) => note.user_id !== auth.user?.id) ?? [];
 
-const difficultyEmojis = [
-  "😴",
-  "🥱",
-  "😐",
-  "😄",
-  "🤔",
-  "🤯",
-  "😓",
-  "😡",
-  "🤬",
-  "😵",
-];
-
 const statusOptions = [
-  null,
+  "never_playing",
+  "retired",
   "incomplete",
   "finished",
   "completed_100",
-  "retired",
-  "never_playing",
 ];
 
 function editNote() {
@@ -77,88 +64,137 @@ watch(
         <span class="text-h6">Status</span>
       </v-list-item>
     </v-card-title>
-    <v-card-text class="py-4 px-8">
-      <v-row no-gutters>
-        <v-col cols="6">
+    <v-card-text class="px-8 py-4">
+      <v-row
+        class="align-center"
+        :class="{ 'text-center': smAndDown }"
+        no-gutters
+      >
+        <v-col cols="12" md="5">
           <v-checkbox
-            label="Backlogged"
             v-model="romUser.backlogged"
             color="romm-accent-1"
             hide-details
-          />
+          >
+            <template v-slot:label
+              ><span>Backlogged</span
+              ><span class="ml-2">{{
+                getEmojiForStatus("backlogged")
+              }}</span></template
+            >
+          </v-checkbox>
           <v-checkbox
-            label="Now playing"
             v-model="romUser.now_playing"
             color="romm-accent-1"
             hide-details
-          />
+          >
+            <template v-slot:label
+              ><span>Now playing</span
+              ><span class="ml-2">{{
+                getEmojiForStatus("now_playing")
+              }}</span></template
+            >
+          </v-checkbox>
           <v-checkbox
-            label="Hidden"
             v-model="romUser.hidden"
             color="romm-accent-1"
             hide-details
-          />
-        </v-col>
-        <v-col cols="6">
-          <div class="d-flex align-center mt-2">
-            <v-label class="text-body-2 mr-4">Rating</v-label>
-            <v-rating
-              hover
-              ripple
-              length="10"
-              size="32"
-              v-model="romUser.rating"
-              @update:model-value="
-                romUser.rating =
-                  typeof $event === 'number' ? $event : parseInt($event)
-              "
-              active-color="romm-accent-1"
-            />
-          </div>
-          <div class="d-flex align-center mt-3">
-            <v-label class="text-body-2 mr-4">Difficulty</v-label>
-            <v-slider
-              v-model="romUser.difficulty"
-              min="1"
-              max="10"
-              step="1"
-              hide-details
-              track-fill-color="romm-accent-1"
-            />
-            <v-label class="ml-2 opacity-100">
-              {{
-                difficultyEmojis[Math.floor(romUser.difficulty) - 1] ?? "😀"
-              }}</v-label
+          >
+            <template v-slot:label
+              ><span>Hidden</span
+              ><span class="ml-2">{{
+                getEmojiForStatus("hidden")
+              }}</span></template
             >
-          </div>
-          <div class="d-flex align-center mt-3">
-            <v-label class="text-body-2 mr-4">Completion %</v-label>
-            <v-slider
-              v-model="romUser.completion"
-              min="1"
-              max="100"
-              step="1"
-              hide-details
-              track-fill-color="romm-accent-1"
-            />
-            <v-label class="text-body-2 ml-2 opacity-100">
-              {{ romUser.completion }}%
-            </v-label>
-          </div>
-          <div class="d-flex align-center mt-3">
+          </v-checkbox>
+        </v-col>
+        <v-col cols="12" md="7">
+          <v-row
+            class="d-flex align-center"
+            :class="{ 'mt-4': smAndDown }"
+            no-gutters
+          >
+            <v-col cols="12" md="2">
+              <v-label>Rating</v-label>
+            </v-col>
+            <v-col cols="12" md="10">
+              <v-rating
+                class="ml-2"
+                hover
+                ripple
+                length="10"
+                size="26"
+                v-model="romUser.rating"
+                @update:model-value="
+                  romUser.rating =
+                    typeof $event === 'number' ? $event : parseInt($event)
+                "
+                active-color="romm-accent-1"
+              />
+            </v-col>
+          </v-row>
+          <v-row class="d-flex align-center mt-4" no-gutters>
+            <v-col cols="12" md="2">
+              <v-label>Difficulty</v-label>
+            </v-col>
+            <v-col cols="11" md="9">
+              <v-slider
+                class="ml-4"
+                v-model="romUser.difficulty"
+                min="1"
+                max="10"
+                step="1"
+                hide-details
+                track-fill-color="romm-accent-1"
+              />
+            </v-col>
+            <v-col cols="1">
+              <v-label class="ml-2 opacity-100">
+                {{
+                  difficultyEmojis[Math.floor(romUser.difficulty) - 1] ??
+                  difficultyEmojis[3]
+                }}
+              </v-label>
+            </v-col>
+          </v-row>
+          <v-row class="d-flex align-center mt-4" no-gutters>
+            <v-col cols="12" md="2">
+              <v-label>Completion %</v-label>
+            </v-col>
+            <v-col cols="11" md="9">
+              <v-slider
+                class="ml-4"
+                v-model="romUser.completion"
+                min="1"
+                max="100"
+                step="1"
+                hide-details
+                track-fill-color="romm-accent-1"
+              />
+            </v-col>
+            <v-col cols="1"
+              ><v-label class="ml-2 opacity-100">
+                {{ romUser.completion }}%
+              </v-label></v-col
+            >
+          </v-row>
+          <div class="d-flex align-center mt-4">
             <v-select
               v-model="romUser.status"
               :items="statusOptions"
               hide-details
               label="Status"
-              dense
+              clearable
               rounded="0"
               variant="outlined"
               density="compact"
               class="mt-1"
             >
               <template v-slot:selection="{ item }">
-                <span>{{ getTextForStatus(item.raw as RomUserStatus) }}</span>
+                <span>{{ getEmojiForStatus(item.raw as RomUserStatus) }}</span
+                ><span class="ml-2">{{
+                  getTextForStatus(item.raw as RomUserStatus)
+                }}</span>
               </template>
               <template v-slot:item="{ item }">
                 <v-list-item
@@ -166,7 +202,10 @@ watch(
                   rounded="0"
                   @click="onStatusItemClick(item.raw)"
                 >
-                  {{ getTextForStatus(item.raw as RomUserStatus) }}
+                  <span>{{ getEmojiForStatus(item.raw as RomUserStatus) }}</span
+                  ><span class="ml-2">{{
+                    getTextForStatus(item.raw as RomUserStatus)
+                  }}</span>
                 </v-list-item>
               </template>
             </v-select>
@@ -175,6 +214,7 @@ watch(
       </v-row>
     </v-card-text>
   </v-card>
+
   <v-card rounded="0">
     <v-card-title class="bg-terciary">
       <v-list-item class="pl-2 pr-0">
diff --git a/frontend/src/utils/index.ts b/frontend/src/utils/index.ts
index 963ca6466..faee99ca9 100644
--- a/frontend/src/utils/index.ts
+++ b/frontend/src/utils/index.ts
@@ -369,6 +369,19 @@ export function isRuffleEmulationSupported(
 
 type PlayingStatus = RomUserStatus | "backlogged" | "now_playing" | "hidden";
 
+export const difficultyEmojis = [
+  "😴",
+  "🥱",
+  "😐",
+  "😄",
+  "🤔",
+  "🤯",
+  "😓",
+  "😡",
+  "🤬",
+  "😵",
+];
+
 export const romStatusMap: Record<
   PlayingStatus,
   { emoji: string; text: string }
@@ -388,11 +401,19 @@ const inverseRomStatusMap = Object.fromEntries(
 ) as Record<string, PlayingStatus>;
 
 export function getEmojiForStatus(status: PlayingStatus) {
-  return romStatusMap[status].emoji;
+  if (status) {
+    return romStatusMap[status].emoji;
+  } else {
+    return null;
+  }
 }
 
 export function getTextForStatus(status: PlayingStatus) {
-  return romStatusMap[status].text;
+  if (status) {
+    return romStatusMap[status].text;
+  } else {
+    return null;
+  }
 }
 
 export function getStatusKeyForText(text: string) {

From 43e9365c7ba7456cd5114d13d7fcb74fdf8a95f1 Mon Sep 17 00:00:00 2001
From: zurdi <zurdizurdo25@gmail.com>
Date: Tue, 29 Oct 2024 15:40:49 +0000
Subject: [PATCH 2/2] fixed margin for personal tab

---
 frontend/src/components/Details/Personal.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/frontend/src/components/Details/Personal.vue b/frontend/src/components/Details/Personal.vue
index bbe0d72a3..8624f4768 100644
--- a/frontend/src/components/Details/Personal.vue
+++ b/frontend/src/components/Details/Personal.vue
@@ -12,7 +12,7 @@ import { useDisplay, useTheme } from "vuetify";
 const props = defineProps<{ rom: DetailedRom }>();
 const auth = storeAuth();
 const theme = useTheme();
-const { smAndDown } = useDisplay();
+const { mdAndUp, smAndDown } = useDisplay();
 const editingNote = ref(false);
 const romUser = ref(props.rom.rom_user);
 const publicNotes =
@@ -119,7 +119,7 @@ watch(
             </v-col>
             <v-col cols="12" md="10">
               <v-rating
-                class="ml-2"
+                :class="{ 'ml-2': mdAndUp }"
                 hover
                 ripple
                 length="10"
@@ -139,7 +139,7 @@ watch(
             </v-col>
             <v-col cols="11" md="9">
               <v-slider
-                class="ml-4"
+                :class="{ 'ml-4': mdAndUp }"
                 v-model="romUser.difficulty"
                 min="1"
                 max="10"
@@ -163,7 +163,7 @@ watch(
             </v-col>
             <v-col cols="11" md="9">
               <v-slider
-                class="ml-4"
+                :class="{ 'ml-4': mdAndUp }"
                 v-model="romUser.completion"
                 min="1"
                 max="100"