improve roms loading time

This commit is contained in:
Georges-Antoine Assi
2024-05-24 10:14:44 -04:00
parent ac59fa16eb
commit 2d4d1b5ae3
8 changed files with 103 additions and 75 deletions

View File

@@ -1,5 +1,6 @@
import functools
from sqlalchemy import delete, or_, select
from sqlalchemy.orm import Session, selectinload
from sqlalchemy.orm import Session, Query, selectinload
from decorators.database import begin_session
from models.platform import Platform
@@ -8,32 +9,39 @@ from models.rom import Rom
from .base_handler import DBBaseHandler
def with_roms(func):
@functools.wraps(func)
def wrapper(*args, **kwargs):
session = kwargs.get("session")
if session is None:
raise ValueError("session is required")
kwargs["query"] = select(Platform).options(
selectinload(Platform.roms).load_only(Rom.id)
)
return func(*args, **kwargs)
return wrapper
class DBPlatformsHandler(DBBaseHandler):
@begin_session
@with_roms
def add_platform(
self, platform: Platform, session: Session = None
self, platform: Platform, query: Query = None, session: Session = None
) -> Platform | None:
session.merge(platform)
session.flush()
return session.scalar(
select(Platform)
.options(selectinload(Platform.roms).load_only(Rom.id))
.filter_by(id=platform.id)
.limit(1)
)
return session.scalar(query.filter_by(id=platform.id).limit(1))
@begin_session
@with_roms
def get_platforms(
self, id: int = None, session: Session = None
self, id: int = None, query: Query = None, session: Session = None
) -> list[Platform] | Platform | None:
return (
session.scalar(
select(Platform)
.options(selectinload(Platform.roms).load_only(Rom.id))
.filter_by(id=id)
.limit(1)
)
session.scalar(query.filter_by(id=id).limit(1))
if id
else (
session.scalars(select(Platform).order_by(Platform.name.asc()))
@@ -43,15 +51,11 @@ class DBPlatformsHandler(DBBaseHandler):
)
@begin_session
@with_roms
def get_platform_by_fs_slug(
self, fs_slug: str, session: Session = None
self, fs_slug: str, query: Query = None, session: Session = None
) -> Platform | None:
return session.scalar(
select(Platform)
.options(selectinload(Platform.roms).load_only(Rom.id))
.filter_by(fs_slug=fs_slug)
.limit(1)
)
return session.scalar(query.filter_by(fs_slug=fs_slug).limit(1))
@begin_session
def delete_platform(self, id: int, session: Session = None) -> int: