Simon/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-03-03 03:07:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3035 from rommapp/romm-3026

Browse Source 
[ROMM-3026] Region/language shortcodes should be case sensitive
This commit is contained in:
Georges-Antoine Assi
2026-02-18 17:43:30 -05:00
committed by GitHub
parent 10f2e1377b 8a56e9b333
commit 445bd9249b
2 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
backend/handler/filesystem/base_handler.py
View File

@@ -83,10 +83,10 @@ REGIONS = (
("W", "World"),
)
REGIONS_BY_SHORTCODE = {region[0].lower(): region[1] for region in REGIONS}
REGIONS_BY_SHORTCODE = {region[0]: region[1] for region in REGIONS}
REGIONS_NAME_KEYS = frozenset(region[1].lower() for region in REGIONS)
LANGUAGES_BY_SHORTCODE = {lang[0].lower(): lang[1] for lang in LANGUAGES}
LANGUAGES_BY_SHORTCODE = {lang[0]: lang[1] for lang in LANGUAGES}
LANGUAGES_NAME_KEYS = frozenset(lang[1].lower() for lang in LANGUAGES)

28
backend/handler/filesystem/roms_handler.py
View File

@@ -334,46 +334,46 @@ class FSRomsHandler(FSHandler):
regions, languages, other_tags = [], [], []
version = revision = ""
for raw in tags:
tag = raw.lower()
for raw_tag in tags:
lower_tag = raw_tag.lower()
# Region by code
if tag in REGIONS_BY_SHORTCODE.keys():
regions.append(REGIONS_BY_SHORTCODE[tag])
if raw_tag in REGIONS_BY_SHORTCODE.keys():
regions.append(REGIONS_BY_SHORTCODE[raw_tag])
continue
if tag in REGIONS_NAME_KEYS:
regions.append(raw)
if lower_tag in REGIONS_NAME_KEYS:
regions.append(raw_tag)
continue
# Language by code
if tag in LANGUAGES_BY_SHORTCODE.keys():
languages.append(LANGUAGES_BY_SHORTCODE[tag])
if raw_tag in LANGUAGES_BY_SHORTCODE.keys():
languages.append(LANGUAGES_BY_SHORTCODE[raw_tag])
continue
if tag in LANGUAGES_NAME_KEYS:
languages.append(raw)
if lower_tag in LANGUAGES_NAME_KEYS:
languages.append(raw_tag)
continue
# Version
version_match = VERSION_TAG_REGEX.match(raw)
version_match = VERSION_TAG_REGEX.match(raw_tag)
if version_match:
version = version_match[1]
continue
# Region prefix
region_match = REGION_TAG_REGEX.match(raw)
region_match = REGION_TAG_REGEX.match(raw_tag)
if region_match:
key = region_match[1].lower()
regions.append(REGIONS_BY_SHORTCODE.get(key, region_match[1]))
continue
# Revision prefix
revision_match = REVISION_TAG_REGEX.match(raw)
revision_match = REVISION_TAG_REGEX.match(raw_tag)
if revision_match:
revision = revision_match[1]
continue
# Anything else
other_tags.append(raw)
other_tags.append(raw_tag)
return ParsedTags(
version=version,