Simon/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-06-28 14:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: address review feedback

Browse Source 
- Derive metadata source columns from Rom model instead of hardcoded list
- Replace getOrderedCoverage() function calls with a computed map to avoid
  redundant sorting on each render

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
cc
2026-03-10 19:27:50 -04:00
parent c8fd7fedde
commit 52c53505a1
2 changed files with 33 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
backend/handler/database/stats_handler.py
View File

@@ -1,5 +1,8 @@
from __future__ import annotations
from sqlalchemy import distinct, func, select
from sqlalchemy.orm import Session
from sqlalchemy.orm.attributes import InstrumentedAttribute
from decorators.database import begin_session
from models.assets import Save, Screenshot, State
@@ -80,30 +83,33 @@ class DBStatsHandler(DBBaseHandler):
or 0
)
# Metadata source columns on the Rom model, keyed by source identifier.
METADATA_SOURCE_COLUMNS: dict[str, "InstrumentedAttribute"] = {
"igdb": Rom.igdb_id,
"ss": Rom.ss_id,
"moby": Rom.moby_id,
"launchbox": Rom.launchbox_id,
"ra": Rom.ra_id,
"hasheous": Rom.hasheous_id,
"tgdb": Rom.tgdb_id,
"flashpoint": Rom.flashpoint_id,
"hltb": Rom.hltb_id,
"gamelist": Rom.gamelist_id,
}
@begin_session
def get_metadata_coverage_by_platform(
self,
session: Session = None, # type: ignore
) -> dict[int, list[dict]]:
"""Get the count of ROMs matched per metadata source, grouped by platform."""
source_keys = [
"igdb", "ss", "moby", "launchbox", "ra",
"hasheous", "tgdb", "flashpoint", "hltb", "gamelist",
]
rows = session.execute(
select(
Rom.platform_id,
func.count(Rom.igdb_id).label("igdb"),
func.count(Rom.ss_id).label("ss"),
func.count(Rom.moby_id).label("moby"),
func.count(Rom.launchbox_id).label("launchbox"),
func.count(Rom.ra_id).label("ra"),
func.count(Rom.hasheous_id).label("hasheous"),
func.count(Rom.tgdb_id).label("tgdb"),
func.count(Rom.flashpoint_id).label("flashpoint"),
func.count(Rom.hltb_id).label("hltb"),
func.count(Rom.gamelist_id).label("gamelist"),
*(
func.count(col).label(key)
for key, col in self.METADATA_SOURCE_COLUMNS.items()
),
)
.select_from(Rom)
.group_by(Rom.platform_id)
@@ -113,7 +119,7 @@ class DBStatsHandler(DBBaseHandler):
for row in rows:
result[row.platform_id] = [
{"source": key, "matched": getattr(row, key)}
for key in source_keys
for key in self.METADATA_SOURCE_COLUMNS
if getattr(row, key) > 0
]
return result