From 87df3e973e9ace8bce2e18960a9c94ebec81b498 Mon Sep 17 00:00:00 2001 From: Georges-Antoine Assi Date: Tue, 22 Jul 2025 22:31:40 -0400 Subject: [PATCH] code review changes --- backend/adapters/services/tests/test_rahasher.py | 2 +- backend/adapters/services/tests/test_retroachivements.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/backend/adapters/services/tests/test_rahasher.py b/backend/adapters/services/tests/test_rahasher.py index faac6e2de..72b7cfced 100644 --- a/backend/adapters/services/tests/test_rahasher.py +++ b/backend/adapters/services/tests/test_rahasher.py @@ -2,7 +2,7 @@ import asyncio from unittest.mock import AsyncMock, patch import pytest -from adapters.services.rahasher import ( # Replace with actual import +from adapters.services.rahasher import ( PLATFORM_SLUG_TO_RETROACHIEVEMENTS_ID, RAHASHER_VALID_HASH_REGEX, RAHasherError, diff --git a/backend/adapters/services/tests/test_retroachivements.py b/backend/adapters/services/tests/test_retroachivements.py index 2c5768d29..ea1becf86 100644 --- a/backend/adapters/services/tests/test_retroachivements.py +++ b/backend/adapters/services/tests/test_retroachivements.py @@ -11,6 +11,8 @@ from adapters.services.retroachievements import ( ) from fastapi import HTTPException, status +INVALID_GAME_ID = 999999 + class TestAuthMiddleware: @patch("adapters.services.retroachievements.RETROACHIEVEMENTS_API_KEY", "test_key") @@ -265,5 +267,5 @@ class TestRetroAchievementsServiceIntegration: "invalid_key", ): # This should handle the error gracefully - result = await service.get_game_extended_details(999999) + result = await service.get_game_extended_details(INVALID_GAME_ID) assert isinstance(result, list)