From ebe570d92df0ba9fafcd5b67df7e8a54220fb4b3 Mon Sep 17 00:00:00 2001 From: Georges-Antoine Assi Date: Sun, 4 Aug 2024 22:05:29 -0400 Subject: [PATCH] Fix to AdditionalContent types --- .github/workflows/pytest.yml | 12 +++---- .github/workflows/typecheck.yml | 36 +++++++++++++++++++ .../components/Details/AdditionalContent.vue | 2 +- 3 files changed, 41 insertions(+), 9 deletions(-) create mode 100644 .github/workflows/typecheck.yml diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml index da63b6b7e..d681f2ebd 100644 --- a/.github/workflows/pytest.yml +++ b/.github/workflows/pytest.yml @@ -2,17 +2,13 @@ name: Run Pytest on: pull_request: - paths-ignore: - - "docker/**" - - "examples/*" - - "frontend/**" + paths: + - "backend/**" push: branches: - "master" - paths-ignore: - - "docker/**" - - "examples/*" - - "frontend/**" + paths: + - "backend/**" permissions: read-all diff --git a/.github/workflows/typecheck.yml b/.github/workflows/typecheck.yml new file mode 100644 index 000000000..80b329205 --- /dev/null +++ b/.github/workflows/typecheck.yml @@ -0,0 +1,36 @@ +name: Run Typescript Typecheck + +on: + pull_request: + paths: + - "frontend/**" + push: + branches: + - "master" + paths: + - "frontend/**" + +permissions: read-all + +jobs: + typecheck: + runs-on: ubuntu-latest + permissions: + checks: write + pull-requests: write + steps: + - name: Checkout repository + uses: actions/checkout@v3 + + - name: Set up Node.js + uses: actions/setup-node@v3 + with: + node-version: "18" + + - name: Install dependencies + run: npm install + working-directory: frontend + + - name: Run typecheck + run: npm run typecheck + working-directory: frontend diff --git a/frontend/src/components/Details/AdditionalContent.vue b/frontend/src/components/Details/AdditionalContent.vue index e8c59855d..4b275e1f5 100644 --- a/frontend/src/components/Details/AdditionalContent.vue +++ b/frontend/src/components/Details/AdditionalContent.vue @@ -24,7 +24,7 @@ const combined = ref([ :href="`https://www.igdb.com/games/${expansion.slug}`" target="_blank" > - +