mirror of
https://github.com/siyuan-note/siyuan.git
synced 2026-06-30 07:46:02 +00:00
* ♻️ Add/update indirect Go dependencies in kernel Update kernel/go.mod and kernel/go.sum to add multiple indirect modules and checksum entries. Notable additions include github.com/fastschema/qjs, github.com/filecoin-project/go-jsonrpc, github.com/ipfs/go-log/v2, go.opencensus.io, go.uber.org/{atomic,multierr,zap}, golang.org/x/xerrors and github.com/golang/groupcache among many transitive entries. Changes ensure transitive dependencies are pinned and go.sum checksums are present (likely produced by `go mod tidy`) to make builds reproducible. * refactor: export bazaar.GetCurrentBackend for kernel plugin platform matching Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * build: promote qjs to direct dependency for kernel plugin system Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(plugin): add KernelPlugin struct with QJS runtime lifecycle and state machine Introduces plugin/plugin.go with KernelPlugin owning an isolated QuickJS runtime, a mutex-serialized call path, RPC method registration/dispatch, Promise awaiting, JSON round-trip result conversion, and WebSocket tracking. Adds sandbox_stub.go as a temporary no-op stub for injectSandboxGlobals. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(plugin): add PluginManager singleton for kernel plugin discovery and lifecycle * feat(plugin): add sandbox injection scaffold with siyuan.log Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(plugin): implement siyuan.storage CRUD scoped to petal storage directory Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(plugin): implement siyuan.fetch with browser-like Response interface * feat(plugin): implement siyuan.socket with browser-compatible WebSocket API - Add sync import for mutex-protected WebSocket connection tracking - Implement __siyuan_socket Go function that creates browser-compatible WebSocket objects - Support send() method with queueing for messages sent before connection opens - Support close() method for closing the WebSocket connection - Track connection state via readyState property (0=CONNECTING, 1=OPEN, 3=CLOSED) - Connect to kernel WebSocket endpoint with automatic auth token injection - Run WebSocket I/O in background goroutine with proper cleanup - Wire up siyuan.socket JS API Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(plugin): implement siyuan.rpc.register for JSON-RPC method registration * feat(plugin): add JSON-RPC 2.0 handler for kernel plugin method dispatch * feat(plugin): register /api/plugin/rpc/:name and /ws/plugin/rpc/:name routes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(plugin): wire kernel plugin manager start/stop into main lifecycle * feat(plugin): hook SetPetalEnabled to start/stop kernel plugins on enable/disable * test(plugin): add unit tests for kernel plugin state machine and eligibility * test(plugin): add comprehensive unit tests for manager, sandbox, and RPC handlers * refactor(plugin): Export IsTargetSupported and update usages Rename isTargetSupported to exported IsTargetSupported and adjust its comment. Replace local calls with bazaar.IsTargetSupported in kernel/bazaar and kernel/plugin/manager, removing the duplicated isKernelEligible helper. Update tests to import bazaar, call the new function, and change expectations to reflect that nil/empty kernel slices are treated as supported (i.e. supported on all platforms). * refactor(plugin): initialize PluginManager in main and update related usages * refactor(plugin): update JWT handling and plugin initialization for kernel plugins * refactor(plugin): enhance plugin initialization and improve sandbox global injections * refactor(kernel-plugin): Refactor plugin RPC registration and sandbox integration - Removed deprecated tests and refactored existing tests for clarity and efficiency. - Updated RPC method registration to use `bind` and `unbind` methods for better clarity. - Enhanced the `injectSandboxGlobals` function to include additional properties for the plugin. - Improved error handling in RPC methods and ensured proper state management for plugins. - Added benchmarks for map to JS conversion performance. - Cleaned up unused imports and organized code structure for better readability. * refactor(plugin): enhance concurrency handling and improve WebSocket integration * refactor(kernel-plugin): enhance RPC method handling and improve function registration * feat(kernel-plugin): add RPC method info retrieval and enhance plugin management * refactor(plugin): add plugin management endpoints and enhance plugin info retrieval * refactor(kernel-plugin): enhance RPC method handling and improve plugin info retrieval * refactor(kernel-plugin): improve error handling and response structures in RPC methods * refactor(kernel-plugin): improve error handling in RPC methods and enhance WebSocket closure management * fix(kernel-plugin): initialize sockets and socketMus maps in NewKernelPlugin * feat(kernel-plugin): add wsWrite helper and fix PushNotification omitempty Add wsWrite method on KernelPlugin that acquires the per-connection write mutex before sending a text frame, returning nil for untracked connections. Fix PushNotification's Params field to use omitempty for JSON-RPC 2.0 §4.2 compliance. Add rpc_test.go with newTestWsPair helper and tests for wsWrite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(kernel-plugin): add BroadcastNotification and per-connection write mutex Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(kernel-plugin): expose siyuan.rpc.broadcast in plugin sandbox Add rpc.broadcast(method, params) binding in injectRpc so JS plugins can push JSON-RPC 2.0 notifications to all connected server clients. Fix deadlock by introducing a dedicated socketsMu RWMutex for the sockets map, decoupling socket tracking from the main plugin mutex that is held during Start()/Eval(). * fix(kernel-plugin): double-unlock in send handler and document PushNotification write-safety Remove spurious mu.Unlock() inside the nil-conn branch of injectSocket's CONNECTING-state send handler; the outer unconditional unlock is sufficient, so the inner one causes a panic under concurrent load. Document that PushNotification bypasses per-connection write serialization and must not be called concurrently with BroadcastNotification/wsWrite on the same connection without external locking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style(kernel-plugin): align struct field declarations in KernelPlugin Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(kernel-plugin): omit params field from JsonRpcRequest when nil (JSON-RPC 2.0 §4.1) Per spec, params MAY be omitted; add omitempty so marshaled requests with no parameters do not emit "params":null. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor(kernel-plugin): change JsonRpcRequest.Params to *json.RawMessage A pointer correctly models the three-way distinction: - nil → params key absent (omitted from marshal output via omitempty) - non-nil → params present (null, array, or object) The previous []byte omitempty omitted the key only for nil/empty slices and could not distinguish absent from explicit null on the wire. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor(kernel-plugin): unify method naming conventions and improve JSON-RPC request handling * fix(kernel-plugin): improve WebSocket message handling and ensure thread safety with mutexes * fix(kernel-plugin): enhance WebSocket handling and improve error management in storage methods * fix(kernel-plugin): rename JsonRpcRequestRaw to JsonRpcInboundRequest and update related methods * fix(kernel-plugin): improve plugin management and error handling in kernel plugin methods * fix(kernel-plugin): rename kernel field to kernels and update related references * feat(kernel-plugin): implement logging and improve concurrency handling in plugin manager and storage methods * feat(kernel-plugin): enhance RPC parameter handling and add JSON array parsing support * refactor(kernel-plugin): refactor RPC handling and improve logging functionality * refactor(kernel-plugin): streamline loggerWrapper function and improve error handling in injectFetch * refactor(kernel-plugin): optimize injectFetch function and enhance error handling * feat(kernel-plugin): add onLoaded hook and enhance plugin lifecycle management * feat(kernel-plugin): add ObjectFreeze and ObjectSeal functions to enhance API security * feat(kernel-plugin): add InitJwtKey function to generate JWT signing key * refactor(kernel-plugin): enhance error handling and logging in plugin lifecycle methods * feat(kernel-plugin): improve WebSocket error handling and add concurrency support in BroadcastNotification * feat(kernel-plugin): enhance error handling in storage and fetch methods with panic recovery * feat(kernel-plugin): enhance PluginManager concurrency and error handling with sync.Map and atomic operations * feat(kernel-plugin): refactor PluginState to use atomic operations for improved concurrency * feat(kernel-plugin): add PluginStateLoaded and update state management in plugin lifecycle * refactor(kernel-plugin): update logging level in loadPetals and refactor loggerWrapper return values * feat(kernel-plugin): simplify invokeHook and enhance error handling in Object methods * feat(kernel-plugin): remove obsolete test files for plugin functionality * refactor(kernel-plugin): implement loggerWrapper and rpcParamsToJsValue functions for improved logging and RPC parameter handling * feat(kernel-plugin): introduce Worker for serializing plugin tasks and enhance context management * refactor(worker): enhance task execution with callback support and graceful shutdown - Introduced a callback mechanism in the Task struct to handle results and errors. - Updated the Run method to accept a callback, allowing immediate handling of task results. - Added a RunSync method for synchronous task execution with result retrieval. - Implemented atomic closure state management to prevent task submission after closure. - Enhanced the Close method to ensure graceful shutdown and wait for the worker to finish processing. * feat(kernel-plugin): refactor storage and RPC methods to use PromiseRun for better error handling * feat(kernel-plugin): enhance plugin event handling with lifecycle and RPC event subscriptions * refactor(kernel-plugin): replace PromiseRun with worker.Run for improved error handling in event and storage methods * chore(kernel-plugin): add goja dependency, drop qjs * chore(kernel-plugin): delete KernelPluginLogger (qjs stdout/stderr only) * refactor(kernel-plugin): replace qjs runtime with goja in plugin.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(kernel-plugin): add sandbox utility tests (pre-rewrite) * refactor(kernel-plugin): rewrite sandbox utility functions for goja Replace goValueToJsValue, getJsContextValue, dispatchEvent with goja implementations; add convertJsonNumbers helper; stub ObjectFreeze and ObjectSeal as no-ops; delete dead qjs-only helpers (invokeRpcMethod, PromiseAwait, rpcParamsToJsValue, parseJsonArrayStringToJsValueArray, parseJsonStringToJsValue, loggerWrapper, ObjectSetDataMethods). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * refactor(kernel-plugin): rewrite sandbox.go inject functions for goja Replace all qjs-based inject functions (injectGlobalContext, injectPlugin, injectLogger, injectEvent, injectStorage, injectFetch, injectSocket, injectRpc) with goja equivalents. Add ObjectSetDataMethods and loggerWrapper helpers. Remove all remaining qjs dead code; ObjectFreeze/ObjectSeal now call Object.freeze/seal via goja AssertFunction. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(kernel-plugin): add plugin lifecycle and RPC integration tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore(kernel-plugin): go mod tidy after qjs removal Remove fastschema/qjs from go.mod and go.sum, add go-sourcemap as indirect (transitive dep of dop251/goja), mark go-sourcemap indirect. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix(kernel-plugin): fix invokeHook early-return on subscribe failure, safe await extraction, and goja value cross-goroutine access in socket methods * refactor(kernel-plugin): replace goValueToJsValue with goValueToJsValueSafely in sandbox functions and tests * feat(plugin): enhance plugin management and error handling - Added GetLoadedPlugin method to retrieve loaded plugin info by name. - Introduced file path for kernel.js in KernelPlugin struct. - Updated Eval method to use the new file path for script execution. - Improved error handling in injectGlobalContext and other injection functions using recover. - Refactored task execution in Worker to use clearer types for task executors and callbacks. - Enhanced storage methods to ensure proper error handling and logging. - Updated loggerWrapper to handle errors more gracefully. - Ensured consistent use of error handling patterns across various plugin methods. * refactor(worker): enhance task execution with goja runtime integration - Updated TaskExecutor and TaskCallback signatures to accept *goja.Runtime. - Modified Worker to start processing tasks with an event loop. - Improved error handling in task execution to catch panics from both executor and callback. - Renamed Close method to Stop for clarity on worker shutdown behavior. * refactor(kernel-plugin): streamline worker implementation and update context handling in plugin methods * refactor(kernel-plugin): update event handler to use byte slices and improve event dispatching * refactor(worker): simplify RunSync method by removing unnecessary select statement * refactor(kernel-plugin): enhance plugin lifecycle management and improve RPC method binding * refactor(kernel-plugin): improve error logging in data methods for better debugging * refactor(kernel-plugin): add version field to plugin data structures and update related methods * refactor(kernel-plugin): replace JsonRpcInboundRequest with JsonRpcRequest and update related methods * refactor(kernel-plugin): enhance plugin lifecycle hooks and improve RPC method invocation * feat(kernel-plugin): improve error handling and response processing in fetch and socket methods * refactor(kernel-plugin): update invokeFunction to handle promise results correctly * refactor(kernel-plugin): streamline event handling and remove unused JSON marshaling functions * refactor(kernel-plugin): improve error handling in start method and add event publishing for lifecycle states * refactor(kernel-plugin): move logging to separate function and execute in goroutines for improved performance * feat(kernel-plugin): add unique ID generation for start and stop events * refactor(kernel-plugin): enhance error handling and concurrency in storage operations Co-authored-by: Copilot <copilot@github.com> * fix(kernel-plugin): remove unexpected resolve in fetch function * feat(kernel-plugin): enhance JSON-RPC request handling with optional parameters and improved error reporting Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): rename await to async in dispatchEvent function for clarity Co-authored-by: Copilot <copilot@github.com> * fix(kernel-plugin): improve error handling in RPC method execution and hook invocation * feat(kernel-plugin): implement custom JSON marshaling for JsonRpcRequest to handle optional parameters * feat(kernel-plugin): add error codes for plugin state and improve error handling in RPC responses Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): clean up context usage and improve error logging for RPC methods * feat(kernel-plugin): add buffer method to object for asynchronous data processing * fix(kernel-plugin): Fixed the problem of blocking when plug-in life cycle function is not bound Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): implement public and private web server handlers and enhance request handling Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): enhance server request handling and introduce server handler invocation Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): enhance response handling and add jsValueToBytes conversion utility Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): comment out public web server route in router * feat(kernel-plugin): add WebSocket and EventSource proxy handlers and update sandbox integration Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): implement HTTP proxy handler with response header forwarding * refactor(kernel-plugin): refactor siyuan.client.* methods * feat(kernel-plugin): add support for EventSource with SSE handling and response header forwarding Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): add SSE support using r3labs/sse library for EventSource handling * feat(kernel-plugin): enhance SSE client with onclose event handling Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): implement SSE event handling and error management in server-sent events * feat(kernel-plugin): refactor SSE handling and introduce request handler utility functions Co-authored-by: Copilot <copilot@github.com> * feat(kernel-plugin): enhance WebSocket message handling with buffered amount tracking and cleanup Co-authored-by: Copilot <copilot@github.com> * perf(kernel-plugin): improve WebSocket message handling with channel-based message sending and error management Co-Authored-By: Copilot <copilot@github.com> * refactor(kernel-plugin): remove invokeServerHandler Co-Authored-By: Copilot <copilot@github.com> * feat(kernel-plugin): implement WebSocket message handling with improved structure and error management Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): Refactor code structure for improved readability and maintainability * refactor(kernel-plugin): streamline HTTP client creation and enhance event source state management Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): enhance WebSocket and SSE handling with improved closure management and error handling Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): optimize WebSocket handling by restructuring state management and improving closure logic Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): simplify header setting and improve null checks in WebSocket and SSE handling Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): update WebSocket request handling to improve error management and consistency * refactor(kernel-plugin): improve WebSocket error handling by adding close message management Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): Refactor WebSocket handling to use gws library - Replaced gorilla/websocket with lxzan/gws for WebSocket connections. - Introduced gwsEventHandler to manage WebSocket events with customizable callbacks. - Updated KernelPlugin to track gws connections and handle message broadcasting. - Refactored RPC WebSocket handling to accommodate new gws structure. - Simplified message sending and connection management logic. - Added utility function to check for undefined JavaScript values. Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): integrate gws library for improved WebSocket handling and error management Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): remove unnecessary error handling in WebSocket request processing * refactor(kernel-plugin): enhance error logging in WebSocket message handling Co-Authored-By: Copilot <copilot@github.com> * refactor(kernel-plugin): replace gwsEventHandler with WsEventHandler and improve WebSocket management Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): integrate chanx for improved event handling in SSE * refactor(kernel-plugin): update handleHttpRequest signature to include gin.Context for improved request handling Co-authored-by: Copilot <copilot@github.com> * refactor(kernel-plugin): optimize WebSocket connection management with context and sync mechanisms * refactor(kernel-plugin): improve error handling and context management in WebSocket and HTTP request handling * refactor(kernel-plugin): enhance WebSocket management with context handling and improved error reporting * fix(kernel-plugin): streamline header export and enhance error handling in injectClient function Co-authored-by: Copilot <copilot@github.com> * perf(kernel-plugin): enhance httpProxy and esProxy functions with improved error handling and content management Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Copilot <copilot@github.com>
504 lines
15 KiB
Go
504 lines
15 KiB
Go
// SiYuan - Refactor your thinking
|
|
// Copyright (c) 2020-present, b3log.org
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
package plugin
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"sync"
|
|
|
|
"github.com/gin-gonic/gin"
|
|
"github.com/lxzan/gws"
|
|
"github.com/siyuan-note/logging"
|
|
"github.com/siyuan-note/siyuan/kernel/util"
|
|
)
|
|
|
|
type JsonRpcErrorCode int
|
|
|
|
const (
|
|
JsonRpcVersion = "2.0"
|
|
|
|
JsonRpcErrorCodeParseError JsonRpcErrorCode = -32700
|
|
JsonRpcErrorCodeInvalidRequest JsonRpcErrorCode = -32600
|
|
JsonRpcErrorCodeMethodNotFound JsonRpcErrorCode = -32601
|
|
JsonRpcErrorCodeInvalidParams JsonRpcErrorCode = -32602
|
|
JsonRpcErrorCodeInternalError JsonRpcErrorCode = -32603
|
|
|
|
// Server-defined error codes (-32099 to -32000)
|
|
JsonRpcErrorCodePluginNotLoaded JsonRpcErrorCode = -32001
|
|
JsonRpcErrorCodePluginNotRunning JsonRpcErrorCode = -32002
|
|
)
|
|
|
|
var (
|
|
JsonRpcErrorParseError = &JsonRpcError{Code: JsonRpcErrorCodeParseError, Message: "Parse error"}
|
|
JsonRpcErrorInvalidRequest = &JsonRpcError{Code: JsonRpcErrorCodeInvalidRequest, Message: "Invalid Request"}
|
|
JsonRpcErrorMethodNotFound = &JsonRpcError{Code: JsonRpcErrorCodeMethodNotFound, Message: "Method not found"}
|
|
JsonRpcErrorInvalidParams = &JsonRpcError{Code: JsonRpcErrorCodeInvalidParams, Message: "Invalid params"}
|
|
JsonRpcErrorInternalError = &JsonRpcError{Code: JsonRpcErrorCodeInternalError, Message: "Internal error"}
|
|
|
|
JsonRpcErrorPluginNotLoaded = &JsonRpcError{Code: JsonRpcErrorCodePluginNotLoaded, Message: "Plugin not loaded"}
|
|
JsonRpcErrorPluginNotRunning = &JsonRpcError{Code: JsonRpcErrorCodePluginNotRunning, Message: "Plugin not running"}
|
|
)
|
|
|
|
func (e *JsonRpcError) Error() string {
|
|
return fmt.Sprintf("JSON RPC Error: %d %s", e.Code, e.Message)
|
|
}
|
|
|
|
// JsonRpcRequest represents a JSON-RPC 2.0 request.
|
|
type JsonRpcRequest struct {
|
|
JsonRpc string `json:"jsonrpc"`
|
|
Method string `json:"method"`
|
|
Params util.Optional[any] `json:"params,omitempty"`
|
|
ID util.Optional[any] `json:"id,omitempty"`
|
|
}
|
|
|
|
func (r JsonRpcRequest) MarshalJSON() ([]byte, error) {
|
|
m := map[string]any{
|
|
"jsonrpc": r.JsonRpc,
|
|
"method": r.Method,
|
|
}
|
|
if r.Params.Exists {
|
|
if r.Params.IsNull {
|
|
m["params"] = nil
|
|
} else {
|
|
m["params"] = r.Params.Value
|
|
}
|
|
}
|
|
if r.ID.Exists {
|
|
if r.ID.IsNull {
|
|
m["id"] = nil
|
|
} else {
|
|
m["id"] = r.ID.Value
|
|
}
|
|
}
|
|
return json.Marshal(m)
|
|
}
|
|
|
|
func (r *JsonRpcRequest) UnmarshalJSON(data []byte) error {
|
|
decoder := json.NewDecoder(bytes.NewReader(data))
|
|
// decoder.DisallowUnknownFields() // Reject unknown fields violates the JSON-RPC spec
|
|
type JsonRpcRequestObject struct {
|
|
JsonRpc util.Optional[string] `json:"jsonrpc"`
|
|
Method util.Optional[string] `json:"method"`
|
|
Params util.Optional[any] `json:"params"`
|
|
ID util.Optional[any] `json:"id"`
|
|
}
|
|
request := JsonRpcRequestObject{}
|
|
if err := decoder.Decode(&request); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Validate jsonrpc field
|
|
if !request.JsonRpc.Exists {
|
|
return fmt.Errorf("missing jsonrpc field")
|
|
}
|
|
if request.JsonRpc.Value != JsonRpcVersion {
|
|
return fmt.Errorf("invalid jsonrpc version: %s", request.JsonRpc.Value)
|
|
}
|
|
|
|
// Validate method field
|
|
if !request.Method.Exists {
|
|
return fmt.Errorf("missing method field")
|
|
}
|
|
|
|
// Validate id field
|
|
if !request.ID.Exists {
|
|
} else if request.ID.IsNull {
|
|
} else if _, ok := request.ID.Value.(string); ok {
|
|
} else if _, ok := request.ID.Value.(float64); ok {
|
|
} else {
|
|
return fmt.Errorf("invalid id field: must be string, number, null or omitted")
|
|
}
|
|
|
|
r.JsonRpc = request.JsonRpc.Value
|
|
r.Method = request.Method.Value
|
|
r.Params = request.Params
|
|
r.ID = request.ID
|
|
return nil
|
|
}
|
|
|
|
// IsNotification returns true if this request is a notification (no ID field).
|
|
func (r *JsonRpcRequest) IsNotification() bool {
|
|
return r.ID.Exists == false
|
|
}
|
|
|
|
// Validate validates the JSON-RPC request structure.
|
|
func (r *JsonRpcRequest) Validate() *JsonRpcError {
|
|
// params is optional, but if present must be either an array (for positional parameters) or an object (for named parameters)
|
|
if !r.Params.Exists {
|
|
} else if _, ok := r.Params.Value.([]any); ok {
|
|
} else if _, ok := r.Params.Value.(map[string]any); ok {
|
|
} else {
|
|
return &JsonRpcError{
|
|
Code: JsonRpcErrorCodeInvalidRequest,
|
|
Message: JsonRpcErrorInvalidRequest.Message,
|
|
Data: "Invalid params: must be array or object if present",
|
|
}
|
|
}
|
|
|
|
// ✅ jsonrpc, method and id fields are validated during unmarshaling, so do not need to validate again here.
|
|
|
|
// if r.JsonRpc != JsonRpcVersion {
|
|
// return JsonRpcErrorInvalidRequest
|
|
// }
|
|
|
|
// if !r.ID.Exists {
|
|
// } else if r.ID.IsNull {
|
|
// } else if _, ok := r.ID.Value.(string); ok {
|
|
// } else if _, ok := r.ID.Value.(float64); ok {
|
|
// } else {
|
|
// return JsonRpcErrorInvalidRequest
|
|
// }
|
|
|
|
return nil
|
|
}
|
|
|
|
// JsonRpcRequestResponse represents a JSON-RPC 2.0 success response.
|
|
// result MUST be present (even if null); error MUST NOT be present.
|
|
type JsonRpcRequestResponse struct {
|
|
JsonRpc string `json:"jsonrpc"`
|
|
Result any `json:"result"`
|
|
ID any `json:"id"`
|
|
}
|
|
|
|
// JsonRpcErrorResponse represents a JSON-RPC 2.0 error response.
|
|
// error MUST be present; result MUST NOT be present.
|
|
type JsonRpcErrorResponse struct {
|
|
JsonRpc string `json:"jsonrpc"`
|
|
Error *JsonRpcError `json:"error"`
|
|
ID any `json:"id"`
|
|
}
|
|
|
|
// JsonRpcError represents a JSON-RPC 2.0 error.
|
|
type JsonRpcError struct {
|
|
Code JsonRpcErrorCode `json:"code"`
|
|
Message string `json:"message"`
|
|
Data any `json:"data,omitempty"`
|
|
}
|
|
|
|
// JsonRpcRequestProcessingResults represents the results of parsing and validating JSON-RPC requests, including any global error and the individual results for each request in a batch.
|
|
type JsonRpcRequestProcessingResults struct {
|
|
Batch bool // Whether the original request was a batch (array) or single request
|
|
GlobalError *JsonRpcErrorResponse // If the entire request is invalid
|
|
Requests []*JsonRpcProcessingRequest
|
|
}
|
|
|
|
// JsonRpcProcessingRequest represents the result of parsing and validating a single JSON-RPC request, including any error if the request is invalid.
|
|
type JsonRpcProcessingRequest struct {
|
|
Request *JsonRpcRequest // The parsed request, or nil if the request was invalid
|
|
Error *JsonRpcErrorResponse // The error if the request was invalid, or nil if the request is valid
|
|
}
|
|
|
|
// JsonRpcProcessingResponse represents the response to a JSON-RPC request, including either the success response or the error response (but not both).
|
|
// - For notifications, both fields will be nil, indicating that no response should be sent.
|
|
// - For successful requests, Response will be non-nil and Error will be nil.
|
|
// - For failed requests, Error will be non-nil and Response will be nil.
|
|
type JsonRpcProcessingResponse struct {
|
|
Response *JsonRpcRequestResponse // The success response, or nil if the request was a notification or the response is an error
|
|
Error *JsonRpcErrorResponse // The error response, or nil if the request was a notification or the response is a success
|
|
}
|
|
|
|
// JsonRpcResponse returns the appropriate response (either success or error) to be sent back to the client, or nil if this is a notification and no response should be sent.
|
|
func (r *JsonRpcProcessingResponse) JsonRpcResponse() any {
|
|
if r.Response != nil {
|
|
return r.Response
|
|
}
|
|
if r.Error != nil {
|
|
return r.Error
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// HandleRpcHttp handles POST /api/plugin/rpc/:name
|
|
// Supports single call, batch call, and notification (no response for notification).
|
|
func HandleRpcHttp(c *gin.Context) {
|
|
name := util.GetRequestUrlStringParam(c, "name")
|
|
p := resolveRunningPlugin(c, name, http.StatusOK)
|
|
if p == nil {
|
|
return
|
|
}
|
|
|
|
body, err := io.ReadAll(c.Request.Body)
|
|
if err != nil {
|
|
c.JSON(http.StatusOK, &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: &JsonRpcError{
|
|
Code: JsonRpcErrorCodeInternalError,
|
|
Message: JsonRpcErrorInternalError.Message,
|
|
Data: fmt.Sprintf("Failed to read request body: %s", err),
|
|
},
|
|
ID: nil,
|
|
})
|
|
return
|
|
}
|
|
|
|
results := parseRpcRequests(body)
|
|
if results.GlobalError != nil {
|
|
c.JSON(http.StatusOK, results.GlobalError)
|
|
return
|
|
}
|
|
|
|
responses := p.dispatchRpcRequests(results.Requests)
|
|
|
|
if !results.Batch {
|
|
// Single request - return single response (or empty for notification)
|
|
if len(responses) > 0 && responses[0] != nil {
|
|
response := responses[0]
|
|
if response.Response != nil {
|
|
c.JSON(http.StatusOK, response.Response)
|
|
return
|
|
} else if response.Error != nil {
|
|
c.JSON(http.StatusOK, response.Error)
|
|
return
|
|
}
|
|
}
|
|
c.Status(http.StatusNoContent)
|
|
return
|
|
}
|
|
|
|
// Batch request - filter out nil responses (notifications) and return array
|
|
filtered := filterRpcResponses(responses)
|
|
|
|
if len(filtered) > 0 {
|
|
c.JSON(http.StatusOK, filtered)
|
|
} else {
|
|
// All notifications in batch - send nothing per spec (MUST NOT return empty array)
|
|
c.Status(http.StatusNoContent)
|
|
}
|
|
}
|
|
|
|
// HandleRpcWebSocket handles GET /ws/plugin/rpc/:name
|
|
// Supports single call, batch call, notification, and server push notifications.
|
|
func HandleRpcWebSocket(c *gin.Context) {
|
|
name := util.GetRequestUrlStringParam(c, "name")
|
|
p := resolveRunningPlugin(c, name, http.StatusNotFound)
|
|
if p == nil {
|
|
return
|
|
}
|
|
|
|
if c.IsWebsocket() == false {
|
|
c.String(http.StatusBadRequest, "This endpoint only accepts WebSocket connections")
|
|
return
|
|
}
|
|
|
|
h := &WsEventHandler{p: p}
|
|
|
|
h.onMessage = func(socket *gws.Conn, message *gws.Message) {
|
|
defer message.Close()
|
|
|
|
results := parseRpcRequests(message.Bytes())
|
|
if results.GlobalError != nil {
|
|
if respBytes, marshalErr := json.Marshal(results.GlobalError); marshalErr == nil {
|
|
socket.WriteAsync(gws.OpcodeText, respBytes, func(err error) {
|
|
if err != nil {
|
|
logging.LogWarnf("[plugin:%s] RPC WebSocket response write failed: %s", name, err)
|
|
}
|
|
})
|
|
} else {
|
|
logging.LogErrorf("[plugin:%s] RPC WebSocket response marshal failed: %s", name, marshalErr)
|
|
}
|
|
return
|
|
}
|
|
|
|
responses := p.dispatchRpcRequests(results.Requests)
|
|
|
|
var responseBytes []byte
|
|
var marshalErr error
|
|
var needToSend bool
|
|
|
|
if !results.Batch {
|
|
if len(responses) > 0 && responses[0] != nil {
|
|
if response := responses[0].JsonRpcResponse(); response != nil {
|
|
needToSend = true
|
|
responseBytes, marshalErr = json.Marshal(response)
|
|
}
|
|
}
|
|
} else {
|
|
filtered := filterRpcResponses(responses)
|
|
if len(filtered) > 0 {
|
|
needToSend = true
|
|
responseBytes, marshalErr = json.Marshal(filtered)
|
|
}
|
|
}
|
|
|
|
if needToSend {
|
|
if marshalErr != nil {
|
|
logging.LogErrorf("[plugin:%s] RPC response marshal failed: %s", name, marshalErr)
|
|
return
|
|
}
|
|
socket.WriteAsync(gws.OpcodeText, responseBytes, func(err error) {
|
|
if err != nil {
|
|
logging.LogWarnf("[plugin:%s] RPC WebSocket response write failed: %s", name, err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
upgrader := gws.NewUpgrader(h, &gws.ServerOption{})
|
|
socket, err := upgrader.Upgrade(c.Writer, c.Request)
|
|
if err != nil {
|
|
logging.LogErrorf("[plugin:%s] RPC WebSocket upgrade failed: %s", name, err)
|
|
return
|
|
}
|
|
|
|
ctx, cancel := context.WithCancel(p.context)
|
|
|
|
var openOnce sync.Once
|
|
var closeOnce sync.Once
|
|
|
|
doOpen := func() {
|
|
go openOnce.Do(func() {
|
|
p.TrackRpcSocket(socket)
|
|
socket.ReadLoop()
|
|
cancel()
|
|
})
|
|
}
|
|
|
|
doClose := func() {
|
|
closeOnce.Do(func() {
|
|
p.UntrackRpcSocket(socket)
|
|
socket.NetConn().Close()
|
|
cancel()
|
|
})
|
|
}
|
|
|
|
defer doClose()
|
|
doOpen()
|
|
<-ctx.Done()
|
|
}
|
|
|
|
// resolveRunningPlugin looks up the plugin by name and writes an error response if it is
|
|
// not found (-32001) or not running (-32002). Returns nil when the caller should abort.
|
|
func resolveRunningPlugin(c *gin.Context, name string, errStatus int) *KernelPlugin {
|
|
p := GetManager().GetPlugin(name)
|
|
if p == nil {
|
|
c.JSON(errStatus, &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: JsonRpcErrorPluginNotLoaded,
|
|
})
|
|
return nil
|
|
}
|
|
if p.State() != PluginStateRunning {
|
|
c.JSON(errStatus, &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: JsonRpcErrorPluginNotRunning,
|
|
})
|
|
return nil
|
|
}
|
|
return p
|
|
}
|
|
|
|
// parseRpcRequest parses a single JSON-RPC request from the given body. The body must be a JSON object.
|
|
func parseRpcRequest(body []byte) (parsedRequest JsonRpcProcessingRequest) {
|
|
var request JsonRpcRequest
|
|
if !json.Valid(body) {
|
|
// Invalid JSON
|
|
parsedRequest.Error = &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: &JsonRpcError{
|
|
Code: JsonRpcErrorCodeParseError,
|
|
Message: JsonRpcErrorParseError.Message,
|
|
Data: "RPC request is not valid JSON",
|
|
},
|
|
ID: nil,
|
|
}
|
|
return
|
|
}
|
|
if err := json.Unmarshal(body, &request); err != nil {
|
|
// Invalid request structure
|
|
parsedRequest.Error = &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: &JsonRpcError{
|
|
Code: JsonRpcErrorCodeInvalidRequest,
|
|
Message: JsonRpcErrorInvalidRequest.Message,
|
|
Data: fmt.Sprintf("RPC request is not a valid JSON-RPC object: %s", err),
|
|
},
|
|
ID: nil,
|
|
}
|
|
return
|
|
}
|
|
parsedRequest.Request = &request
|
|
return
|
|
}
|
|
|
|
// parseRpcRequests parses the given body into one or more JSON-RPC requests, handling both single and batch requests.
|
|
func parseRpcRequests(body []byte) (results JsonRpcRequestProcessingResults) {
|
|
if !json.Valid(body) {
|
|
// Invalid JSON
|
|
results.GlobalError = &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: &JsonRpcError{
|
|
Code: JsonRpcErrorCodeParseError,
|
|
Message: JsonRpcErrorParseError.Message,
|
|
Data: "RPC request is not valid JSON",
|
|
},
|
|
ID: nil,
|
|
}
|
|
return
|
|
}
|
|
|
|
var jsonArray []json.RawMessage
|
|
if err := json.Unmarshal(body, &jsonArray); err != nil {
|
|
// single request
|
|
request := parseRpcRequest(body)
|
|
results.Requests = append(results.Requests, &request)
|
|
return
|
|
} else {
|
|
// batch request
|
|
if len(jsonArray) == 0 {
|
|
// per spec, an empty array is invalid
|
|
results.GlobalError = &JsonRpcErrorResponse{
|
|
JsonRpc: JsonRpcVersion,
|
|
Error: &JsonRpcError{
|
|
Code: JsonRpcErrorCodeInvalidRequest,
|
|
Message: JsonRpcErrorInvalidRequest.Message,
|
|
Data: "RPC request is not allowed to be an empty array",
|
|
},
|
|
ID: nil,
|
|
}
|
|
return
|
|
}
|
|
|
|
results.Batch = true
|
|
results.Requests = make([]*JsonRpcProcessingRequest, len(jsonArray))
|
|
for i, raw := range jsonArray {
|
|
request := parseRpcRequest(raw)
|
|
results.Requests[i] = &request
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
// filterRpcResponses filters out nil responses (for notifications) and extracts the actual response objects for non-nil responses.
|
|
func filterRpcResponses(responses []*JsonRpcProcessingResponse) []any {
|
|
filtered := make([]any, 0, len(responses))
|
|
for _, response := range responses {
|
|
if response != nil {
|
|
if response.Response != nil {
|
|
filtered = append(filtered, response.Response)
|
|
} else if response.Error != nil {
|
|
filtered = append(filtered, response.Error)
|
|
}
|
|
}
|
|
}
|
|
return filtered
|
|
}
|