From 752b683494f482e93ebcaf880c1c99dc98580bae Mon Sep 17 00:00:00 2001
From: Yuri Kuznetsov <yurikuzn@users.noreply.github.com>
Date: Mon, 18 Apr 2022 19:11:40 +0300
Subject: [PATCH] config fill missing default parameters on rebuild

---
 application/Espo/Core/DataManager.php         | 11 ++-
 .../Config/MissingDefaultParamsSaver.php      | 82 +++++++++++++++++++
 2 files changed, 92 insertions(+), 1 deletion(-)
 create mode 100644 application/Espo/Core/Utils/Config/MissingDefaultParamsSaver.php

diff --git a/application/Espo/Core/DataManager.php b/application/Espo/Core/DataManager.php
index bc441629f5..76ed442890 100644
--- a/application/Espo/Core/DataManager.php
+++ b/application/Espo/Core/DataManager.php
@@ -29,6 +29,8 @@
 
 namespace Espo\Core;
 
+use Espo\Core\Utils\Config\MissingDefaultParamsSaver as ConfigMissingDefaultParamsSaver;
+
 use Espo\Core\{
     Exceptions\Error,
     ORM\EntityManager,
@@ -74,6 +76,8 @@ class DataManager
 
     private $rebuildActionProcessor;
 
+    private ConfigMissingDefaultParamsSaver $configMissingDefaultParamsSaver;
+
     private string $cachePath = 'data/cache';
 
     public function __construct(
@@ -87,7 +91,8 @@ class DataManager
         SchemaProxy $schemaProxy,
         Log $log,
         Module $module,
-        RebuildActionProcessor $rebuildActionProcessor
+        RebuildActionProcessor $rebuildActionProcessor,
+        ConfigMissingDefaultParamsSaver $configMissingDefaultParamsSaver
     ) {
         $this->entityManager = $entityManager;
         $this->config = $config;
@@ -100,6 +105,7 @@ class DataManager
         $this->log = $log;
         $this->module = $module;
         $this->rebuildActionProcessor = $rebuildActionProcessor;
+        $this->configMissingDefaultParamsSaver = $configMissingDefaultParamsSaver;
     }
 
     /**
@@ -110,13 +116,16 @@ class DataManager
     public function rebuild(?array $entityList = null): void
     {
         $this->clearCache();
+
         $this->disableHooks();
+
         $this->checkModules();
         $this->populateConfigParameters();
         $this->rebuildMetadata();
         $this->rebuildDatabase($entityList);
 
         $this->rebuildActionProcessor->process();
+        $this->configMissingDefaultParamsSaver->process();
 
         $this->enableHooks();
     }
diff --git a/application/Espo/Core/Utils/Config/MissingDefaultParamsSaver.php b/application/Espo/Core/Utils/Config/MissingDefaultParamsSaver.php
new file mode 100644
index 0000000000..8e3ff944c3
--- /dev/null
+++ b/application/Espo/Core/Utils/Config/MissingDefaultParamsSaver.php
@@ -0,0 +1,82 @@
+<?php
+/************************************************************************
+ * This file is part of EspoCRM.
+ *
+ * EspoCRM - Open Source CRM application.
+ * Copyright (C) 2014-2022 Yurii Kuznietsov, Taras Machyshyn, Oleksii Avramenko
+ * Website: https://www.espocrm.com
+ *
+ * EspoCRM is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * EspoCRM is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with EspoCRM. If not, see http://www.gnu.org/licenses/.
+ *
+ * The interactive user interfaces in modified source and object code versions
+ * of this program must display Appropriate Legal Notices, as required under
+ * Section 5 of the GNU General Public License version 3.
+ *
+ * In accordance with Section 7(b) of the GNU General Public License version 3,
+ * these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
+ ************************************************************************/
+
+namespace Espo\Core\Utils\Config;
+
+use Espo\Core\Utils\Config;
+use Espo\Core\Utils\Config\ConfigWriter;
+use Espo\Core\Utils\File\Manager as FileManager;
+
+use Espo\Core\Exceptions\Error;
+
+class MissingDefaultParamsSaver
+{
+    private Config $config;
+
+    private ConfigWriter $configWriter;
+
+    private FileManager $fileManager;
+
+    private string $defaultConfigPath = 'application/Espo/Resources/defaults/config.php';
+
+    public function __construct(Config $config, ConfigWriter $configWriter, FileManager $fileManager)
+    {
+        $this->config = $config;
+        $this->configWriter = $configWriter;
+        $this->fileManager = $fileManager;
+    }
+
+    public function process(): void
+    {
+        $data = $this->fileManager->getPhpSafeContents($this->defaultConfigPath);
+
+        if (!is_array($data)) {
+            throw new Error();
+        }
+
+        /** @var array<string,mixed> $data */
+
+        $newData = [];
+
+        foreach ($data as $param => $value) {
+            if ($this->config->has($param)) {
+                continue;
+            }
+
+            $newData[$param] = $value;
+        }
+
+        if (!count($newData)) {
+            return;
+        }
+
+        $this->configWriter->setMultiple($newData);
+        $this->configWriter->save();
+    }
+}