Merge pull request #996 from rommapp/fix-nav-guards-returns

Have navigation guards return true or explicitly call next

frontend/src/plugins/router.ts

@@ -77,12 +77,13 @@ const router = createRouter({
   routes,
 });
 
-router.beforeEach((to) => {
+router.beforeEach((to, _from, next) => {
   const heartbeat = storeHeartbeat();
   if (to.name == "setup" && !heartbeat.value.SHOW_SETUP_WIZARD) {
-    router.push({ name: "dashboard" });
+    next({ name: "dashboard" });
+  } else {
+    next();
   }
-  // TODO: check permission for views. Ex: view user can access to /scan view
 });
 
 router.afterEach(() => {

frontend/src/views/Gallery/Collection.vue

@@ -226,7 +226,7 @@ onMounted(async () => {
 onBeforeRouteUpdate(async (to, from) => {
   // Triggers when change param of the same route
   // Reset store if switching to another collection
-  if (to.path === from.path) return;
+  if (to.path === from.path) return true;
 
   resetGallery();
 
@@ -241,6 +241,8 @@ onBeforeRouteUpdate(async (to, from) => {
 
   await fetchRoms();
   setFilters();
+
+  return true;
 });
 
 onBeforeUnmount(() => {

frontend/src/views/Gallery/Platform.vue

@@ -227,7 +227,7 @@ onMounted(async () => {
 onBeforeRouteUpdate(async (to, from) => {
   // Triggers when change param of the same route
   // Reset store if switching to another platform
-  if (to.path === from.path) return;
+  if (to.path === from.path) return true;
 
   resetGallery();
 
@@ -242,6 +242,8 @@ onBeforeRouteUpdate(async (to, from) => {
 
   await fetchRoms();
   setFilters();
+
+  return true;
 });
 
 onBeforeUnmount(() => {

frontend/src/views/GameDetails.vue

@@ -84,6 +84,7 @@ onBeforeMount(async () => {
 
 onBeforeRouteLeave(() => {
   currentRom.value = null;
+  return true;
 });
 
 watch(