Simon/romm
1
0
Fork 0
mirror of https://github.com/rommapp/romm.git synced 2026-06-28 14:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(playmatch): filter falsy provider ids and surface non-2xx responses

Browse Source
This commit is contained in:
Yukine
2026-04-21 10:55:20 +02:00
parent fee40dc355
commit 5ecdc8fd13
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
backend/handler/metadata/playmatch_handler.py
View File

@@ -183,7 +183,7 @@ class PlaymatchHandler(MetadataHandler):
return PlaymatchRomMatch(igdb_id=igdb_id)
async def submit_manual_match_suggestion(self, rom: Rom) -> None:
"""Fire-and-forget suggestion POST. No-ops if disabled or unmatched; never raises."""
"""Fire-and-forget suggestion POST. No-ops if disabled or no provider IDs are set; never raises."""
try:
if not self.is_enabled():
return
@@ -191,7 +191,7 @@ class PlaymatchHandler(MetadataHandler):
mappings = [
{"provider": tag, "providerId": str(getattr(rom, attr))}
for attr, tag in _PLAYMATCH_PROVIDER_TAGS
if getattr(rom, attr, None) not in (None, "")
if getattr(rom, attr, None)
]
if not mappings:
return
@@ -221,11 +221,12 @@ class PlaymatchHandler(MetadataHandler):
}
httpx_client = ctx_httpx_client.get()
await httpx_client.post(
res = await httpx_client.post(
self.suggestion_url,
json=payload,
headers={"user-agent": f"RomM/{get_version()}"},
timeout=30,
)
res.raise_for_status()
except Exception:
log.debug("Playmatch match suggestion failed (ignored)", exc_info=True)