copilot-swe-agent[bot] 90bbf6c9d1 fix: fetch metadata for manually-set IDs on UNMATCHED scan
When a user manually sets metadata IDs (e.g., ra_id, launchbox_id, hasheous_id)
via the UI and then runs "Refresh Metadata" (which defaults to UNMATCHED scan type),
no metadata was fetched because UNMATCHED conditions checked `not rom.xxx_id` — so
if the ID was already set, the handler was skipped entirely.

Fix: Change each handler's UNMATCHED condition to also trigger when the ID is set
but the corresponding metadata dict is empty (i.e., `not rom.xxx_id or not rom.xxx_metadata`).
For handlers that support ID-based lookup (RA, Launchbox, IGDB, MobyGames, SS,
Flashpoint), also add the `get_rom_by_id` path inside the function.

For Hasheous: when hash lookup fails but `hasheous_id` is set on an existing ROM
(not newly added), return a partial HasheousRom built from the existing sub-IDs
(igdb_id, ra_id, tgdb_id) so the downstream get_igdb_game / get_ra_game proxy
calls can still enrich the ROM.

Add three targeted tests to validate:
- UNMATCHED scan fetches RA metadata when ra_id is set but ra_metadata is empty
- UNMATCHED scan skips RA when both ra_id and ra_metadata are already populated
- UNMATCHED scan passes existing sub-IDs to Hasheous proxies when hash lookup fails

Agent-Logs-Url: https://github.com/rommapp/romm/sessions/098b482f-9f73-4f35-819a-b55004a79b13

Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>
2026-05-21 11:41:23 +00:00
2025-08-07 09:34:43 -04:00
2026-05-17 19:07:57 -04:00
2026-05-17 12:43:33 -04:00
2026-04-15 19:20:17 -04:00
2026-03-08 09:40:29 -04:00
2025-07-03 23:37:00 -03:00
2024-05-21 19:22:14 -04:00
2026-01-02 17:58:19 +00:00
2026-04-03 10:54:31 -04:00
2026-05-17 19:07:57 -04:00
2026-05-17 17:52:14 -04:00
2024-02-11 16:41:36 +01:00
2026-04-01 20:49:08 -04:00
2024-07-09 13:43:14 +02:00

romm logo

A beautiful, powerful, self-hosted ROM manager and player.

discord-badge-img docs-badge-img license-badge-img release-badge-img docker-pulls-badge-img

Overview

RomM (ROM Manager) allows you to scan, enrich, browse and play your game collection with a clean and responsive interface. With support for multiple platforms, various naming schemes, and custom tags, RomM is a must-have for anyone who plays on emulators.

Features

  • Scan and enhance your game library with metadata from IGDB, Screenscraper and MobyGames
  • Fetch custom artwork from SteamGridDB
  • Display your achievements from Retroachievements
  • Metadata available for 400+ platforms
  • Play games directly from the browser using EmulatorJS and RuffleRS
  • Share your library with friends with limited access and permissions
  • Official apps for Playnite, Android and CFWs
  • Supports multi-disk games, DLCs, mods, hacks, patches, and manuals
  • Parse and filter by tags in filenames
  • View, upload, update, and delete games from any modern web browser

Preview

🖥 Desktop 📱 Mobile
desktop preview mobile preview

Installation

To start using RomM, check out the Quick Start Guide in the docs. If you are having issues with RomM, please review the page for troubleshooting steps.

Contributing

To contribute to RomM, please check Contribution Guide.

Community

Here are a few projects maintained by members of our community. Please note that the RomM team does not regularly review their source code.

Mobile

Desktop

Handhelds

Other

[🔷] Official first-party app

Join us on Discord, where you can ask questions, submit ideas, get help, showcase your collection, and discuss RomM with other users.

discord-invite-img

Technical Support

If you have any issues with RomM, please open an issue in this repository.

Financial Support

Consider supporting the development of this project on Open Collective. All funds will be used to cover the costs of hosting, development, and maintenance of RomM.

oc-donate-img

Our Friends

Here are a few projects that we think you might like:

  • EmulatorJS: An embeddable, browser-based emulator
  • RetroDECK: Retro gaming on SteamOS and Linux
  • ES-DE Frontend: Emulator frontend for Linux, macOS and Windows
  • Gaseous: Another ROM manager with web-based emulator
  • Retrom: A centralized game library/collection management service
  • Drop: Steam-like experience for DRM-free games
  • LanCommander: Digital game platform for PC games
  • Steam ROM Manager: An app for managing ROMs in Steam

hackernews badge   selfh.st badge   Aikido Security Audit Report
Languages
Python 45.1%
Vue 42%
TypeScript 11.7%
CSS 0.7%
Shell 0.2%
Other 0.3%