mirror of
https://github.com/rommapp/romm.git
synced 2026-06-28 06:46:00 +00:00
90bbf6c9d1
When a user manually sets metadata IDs (e.g., ra_id, launchbox_id, hasheous_id) via the UI and then runs "Refresh Metadata" (which defaults to UNMATCHED scan type), no metadata was fetched because UNMATCHED conditions checked `not rom.xxx_id` — so if the ID was already set, the handler was skipped entirely. Fix: Change each handler's UNMATCHED condition to also trigger when the ID is set but the corresponding metadata dict is empty (i.e., `not rom.xxx_id or not rom.xxx_metadata`). For handlers that support ID-based lookup (RA, Launchbox, IGDB, MobyGames, SS, Flashpoint), also add the `get_rom_by_id` path inside the function. For Hasheous: when hash lookup fails but `hasheous_id` is set on an existing ROM (not newly added), return a partial HasheousRom built from the existing sub-IDs (igdb_id, ra_id, tgdb_id) so the downstream get_igdb_game / get_ra_game proxy calls can still enrich the ROM. Add three targeted tests to validate: - UNMATCHED scan fetches RA metadata when ra_id is set but ra_metadata is empty - UNMATCHED scan skips RA when both ra_id and ra_metadata are already populated - UNMATCHED scan passes existing sub-IDs to Hasheous proxies when hash lookup fails Agent-Logs-Url: https://github.com/rommapp/romm/sessions/098b482f-9f73-4f35-819a-b55004a79b13 Co-authored-by: gantoine <3247106+gantoine@users.noreply.github.com>