viscous/textbee
1
0
Fork 0
mirror of https://github.com/vernu/textbee.git synced 2026-04-18 11:29:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): use subscription document _id in webhook updateOne filters

Browse Source 
Mongoose 9 updateOne expects an ObjectId for _id; webhookSubscriptionId
was inferred as ObjectId | WebhookSubscription in CI, causing TS2769.
Use webhookSubscription._id after findById instead.

Made-with: Cursor
This commit is contained in:
isra el
2026-04-05 17:43:18 +03:00
parent 6f5190aade
commit 1a5e095c56
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/src/webhook/webhook.service.ts
View File

@@ -1,5 +1,5 @@
import { HttpException, HttpStatus, Injectable } from '@nestjs/common'
import { Model } from 'mongoose'
import { Model, Types } from 'mongoose'
import {
WebhookSubscription,
WebhookSubscriptionDocument,
@@ -418,7 +418,9 @@ export class WebhookService {
return
}
const webhookSubscriptionId = webhookNotification.webhookSubscription
const wsRef = webhookNotification.webhookSubscription
const webhookSubscriptionId =
wsRef instanceof Types.ObjectId ? wsRef : wsRef._id!
const webhookSubscription = await this.webhookSubscriptionModel.findById(
webhookSubscriptionId,
)
@@ -478,7 +480,7 @@ export class WebhookService {
await webhookNotification.save()
await this.webhookSubscriptionModel.updateOne(
{ _id: webhookSubscriptionId },
{ _id: webhookSubscription._id },
{
$inc: { successfulDeliveryCount: 1, deliveryAttemptCount: 1 },
$set: { lastDeliverySuccessAt: now },
@@ -528,7 +530,7 @@ export class WebhookService {
await webhookNotification.save()
await this.webhookSubscriptionModel.updateOne(
{ _id: webhookSubscriptionId },
{ _id: webhookSubscription._id },
{
$inc: { deliveryFailureCount: 1, deliveryAttemptCount: 1 },
$set: { lastDeliveryFailureAt: now },